Make IonQ native gate docstring format correctly #5416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabacon
requested review from
a team,
ColemanCollins,
cduck,
gmauricio,
nakardo and
vtomole
as code owners
Collaborator
Author
Cynocracy
approved these changes
May 27, 2022
Contributor
Cynocracy
left a comment
Cynocracy
left a comment
There was a problem hiding this comment.
The unitaries for the document() strings are pretty and I feel like I learned a bit more about the gates by reading them :)
| The unitary matrix of this gate is: | ||
| $$ | ||
| \begin{bmatrix} | ||
| 0 & 1 \\ |
Contributor
There was a problem hiding this comment.
Ah, this is meant to document the null instance? neat
Collaborator
Author
There was a problem hiding this comment.
yeah, docs constants.
| \end{bmatrix} | ||
| $$ | ||
| See [IonQ best practices](https://ionq.com/best-practices){:external}. |
Contributor
There was a problem hiding this comment.
If you don't mind changing them, these can be https://ionq.com/docs/getting-started-with-native-gates now
gmauricio
approved these changes
Jun 6, 2022
dabacon
added
the
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.