Do not generate default repetition ids if use_repetition_ids=False #5419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think the |
daxfohl
reviewed
May 31, 2022
| if self.use_repetition_ids: | ||
| loop_size = abs(self.repetitions) | ||
| if not self.repetition_ids: | ||
| object.__setattr__(self, 'repetition_ids', self._default_repetition_ids()) |
Collaborator
There was a problem hiding this comment.
Could all these be consolidated by having default_repetition_ids return None if use_repetition_ids is false?
Contributor
Author
There was a problem hiding this comment.
Changed to do the self.use_repetition_ids check in self._default_repetition_ids.
Contributor
Author
|
@daxfohl, I can't seem to re-request review from you, but this is ready for review again after addressing your comments. PTAL |
Collaborator
|
lgtm |
Contributor
Author
|
@daxfohl, thanks for the review! Looks like you commented instead of approving. |
daxfohl
approved these changes
May 31, 2022
dstrain115
approved these changes
May 31, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5418