Skip to content

Make all non-analytical gate decompositions respect global phase #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2022
Merged

Make all non-analytical gate decompositions respect global phase #5420

merged 4 commits into from
May 31, 2022

Conversation

@tanujkhattar
Copy link
Collaborator

@tanujkhattar tanujkhattar commented May 31, 2022

Fixes #4275

@tanujkhattar tanujkhattar requested review from a team, cduck and vtomole as code owners May 31, 2022 16:11
dabacon
dabacon approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one comment

@CirqBot CirqBot added the size: M 50< lines changed <250 label May 31, 2022
@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 31, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 31, 2022
@CirqBot CirqBot merged commit 0d55968 into master May 31, 2022
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 31, 2022
@CirqBot CirqBot deleted the decomp_respect_global_phase branch May 31, 2022 17:30
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 31, 2022
@tanujkhattar tanujkhattar mentioned this pull request Jun 13, 2022
Merged
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Make all non-analytical gate decompositions respect global phase (qua…
c9d3756 
…ntumlib#5420)

Fixes quantumlib#4275
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
Make all non-analytical gate decompositions respect global phase (qua…
9050f33 
…ntumlib#5420)

Fixes quantumlib#4275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dabacon dabacon dabacon approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton MichaelBroughton was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels

size: M 50< lines changed <250

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gate decompositions ignore global phase

4 participants

@tanujkhattar @dabacon @MichaelBroughton @CirqBot