The number of exponents is too damn high #5456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabacon
changed the title
dabacon
changed the title
vtomole
approved these changes
Jun 6, 2022
Collaborator
vtomole
left a comment
vtomole
left a comment
There was a problem hiding this comment.
LGTM given these are optional arguments.
viathor
approved these changes
Jun 6, 2022
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Just going to throw this out there for comment. `assist_consistent_protocols` is used in a huge number of tests (many of which are themselves parameterized tests). We test all of the protocols for a large number of different `pow`ed versions of the gate. This ends up being something like 10% or our test time. I've reduced this number down to what I think is a bit more reasonable, (0, itself, inverse, a non-zero float, a symbol).
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Just going to throw this out there for comment. `assist_consistent_protocols` is used in a huge number of tests (many of which are themselves parameterized tests). We test all of the protocols for a large number of different `pow`ed versions of the gate. This ends up being something like 10% or our test time. I've reduced this number down to what I think is a bit more reasonable, (0, itself, inverse, a non-zero float, a symbol).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just going to throw this out there for comment.
assist_consistent_protocolsis used in a huge number of tests (many of which are themselves parameterized tests). We test all of the protocols for a large number of differentpowed versions of the gate. This ends up being something like 10% or our test time.I've reduced this number down to what I think is a bit more reasonable, (0, itself, inverse, a non-zero float, a symbol).