Add information on new vendor setup #5485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a blurb about submitting RFC and attending cirq cync - Adds information about possible options and different pieces needed for an integration. - Links to this in two places.
dabacon
approved these changes
Jun 11, 2022
Collaborator
dabacon
left a comment
dabacon
left a comment
There was a problem hiding this comment.
LGTM, one nit and a question
docs/dev/rfc_process.md
Outdated
| Several things are needed for a successful integration: | ||
|
|
||
| * Plan for including external dependencies (if needed). | ||
| * Access and authentication |
Collaborator
There was a problem hiding this comment.
nit missing "." here and one below.
| currently soliciting additional vendors. However, if you are considering | ||
| integrating with cirq, we would highly encourage you to engage with the | ||
| cirq-maintainer team through attending the weekly cirq cync and submitting | ||
| an RFC as specified above. Everyone benefits from a well-maintained, user |
Collaborator
There was a problem hiding this comment.
do we have an example of a vendor integration that would be useful to link to?
Collaborator
Author
There was a problem hiding this comment.
Linked to hardware pages. I was reluctant to pick one in particular.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Add information on new vendor setup - Add a blurb about submitting RFC and attending cirq cync - Adds information about possible options and different pieces needed for an integration. - Links to this in two places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for an integration.
Fixes: #3820