Skip to content

Conversation

@MichaelBroughton
Copy link
Collaborator

@MichaelBroughton MichaelBroughton commented Jun 16, 2022

Closes #5521. Closes #5463.

@augustehirth Can we open new PRs for anything we want to salvage from these into the vendor packages and get these removed ?

@MichaelBroughton MichaelBroughton requested review from a team, cduck and vtomole as code owners June 16, 2022 20:16
@MichaelBroughton MichaelBroughton requested a review from viathor June 16, 2022 20:16
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jun 16, 2022
@augustehirth
Copy link
Collaborator

augustehirth commented Jun 16, 2022

LGTM. Let's remove them now and we'll add back the excised parts later, if applicable.

You need to remove them from the _book.yaml and /hardware/_index.yaml indexes. I'd suggest the exact deletions in github if I knew how D:

I've already checked and I don't think there are any other links pointing to these pages that need to be removed.

@MichaelBroughton
Copy link
Collaborator Author

Good catch, updated those files now PTAL.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 16, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 16, 2022
@pavoljuhas pavoljuhas removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 17, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 17, 2022
@CirqBot CirqBot merged commit cb9c043 into quantumlib:master Jun 17, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 17, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Closes quantumlib#5521. Closes quantumlib#5463.

@augustehirth Can we open new PRs for anything we want to salvage from these into the vendor packages and get these removed ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L 250< lines changed <1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove neutral atoms tutorial? Remove ion device tutorial?

5 participants