Skip to content

Conversation

@vtomole
Copy link
Collaborator

@vtomole vtomole commented Jun 16, 2022

Fixes #2041

@vtomole vtomole changed the title Cast cirq.apply_unitary's ApplyUnitaryArgs.target_tensor and `ApplyUnitaryArgs.available_buffer inputs to np.complex128 Cast cirq.apply_unitary's ApplyUnitaryArgs.target_tensor and `=ApplyUnitaryArgs.available_buffer inputs to np.complex128 Jun 16, 2022
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jun 16, 2022
@vtomole vtomole changed the title Cast cirq.apply_unitary's ApplyUnitaryArgs.target_tensor and `=ApplyUnitaryArgs.available_buffer inputs to np.complex128 Cast cirq.apply_unitary's ApplyUnitaryArgs.target_tensor and ApplyUnitaryArgs.available_buffer inputs to np.complex128 Jun 16, 2022
@vtomole vtomole force-pushed the cast_apply_unitary branch from e883bfa to 18545c7 Compare June 22, 2022 19:53
@vtomole vtomole changed the title Cast cirq.apply_unitary's ApplyUnitaryArgs.target_tensor and ApplyUnitaryArgs.available_buffer inputs to np.complex128 Raise error instead of warning when downcasting from complex in apply_unitary Jun 22, 2022
@vtomole vtomole marked this pull request as ready for review June 22, 2022 20:09
@vtomole vtomole requested review from a team and cduck as code owners June 22, 2022 20:09
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 23, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 23, 2022
@CirqBot CirqBot merged commit ca8585e into quantumlib:master Jun 23, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 23, 2022
@vtomole vtomole deleted the cast_apply_unitary branch June 23, 2022 22:23
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: downcasting from complex in apply_unitary

3 participants