Skip to content

Replace shell_tools.run_shell --> shell_tools.run #5545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2022
Merged

Replace shell_tools.run_shell --> shell_tools.run #5545

merged 1 commit into from
Jun 17, 2022

Conversation

@pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Jun 17, 2022

Stop using shell_tools.run_shell which is slated for removal.

Partially implements #4394

@pavoljuhas pavoljuhas requested review from a team, cduck and vtomole as code owners June 17, 2022 00:19
@pavoljuhas pavoljuhas requested a review from mpharrigan June 17, 2022 00:19
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jun 17, 2022
dabacon
dabacon approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 17, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 17, 2022
@CirqBot CirqBot merged commit 3cc607d into quantumlib:master Jun 17, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 17, 2022
@pavoljuhas pavoljuhas deleted the replace-shell_tools.run_shell branch June 17, 2022 16:41
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@pavoljuhas @rht
Replace shell_tools.run_shell --> shell_tools.run (quantumlib#5545)
33cda2a 
Stop using shell_tools.run_shell which is slated for removal.

Partially implements quantumlib#4394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dabacon dabacon dabacon approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@mpharrigan mpharrigan Awaiting requested review from mpharrigan mpharrigan was automatically assigned from quantumlib/cirq-maintainers

Assignees

No one assigned

Labels

size: L 250< lines changed <1000

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pavoljuhas @dabacon @CirqBot