Remove XmonDevice. #5562
Merged
Remove XmonDevice. #5562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
maffoo
reviewed
Jun 22, 2022
Contributor
maffoo
left a comment
maffoo
left a comment
There was a problem hiding this comment.
Minor comments about some if TYPE_CHECKING imports that can be removed, otherwise LGTM.
| seed: Optional seed value for random number generator. | ||
| """ | ||
| self._c = device.qubits | ||
| self._c = cast(Set[cirq.GridQubit], device.metadata.qubit_set) |
Contributor
There was a problem hiding this comment.
Does GridDevice not define its qubit_set as containing GridQubit? I guess this is fine for now, but would be nice to fix in the future.
Collaborator
Author
There was a problem hiding this comment.
Yeah, that might be something to look into.
maffoo
approved these changes
Jun 22, 2022
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Removes final v0.15 device deprecations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes final v0.15 device deprecations.