Skip to content

Conversation

@MichaelBroughton
Copy link
Collaborator

No description provided.

@MichaelBroughton MichaelBroughton requested review from a team, cduck and vtomole as code owners June 22, 2022 23:57
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jun 22, 2022
@pavoljuhas
Copy link
Collaborator

Perhaps this one needs to be replaces with device.qubits ?

"\n",
"# Get qubit set\n",
"qubits = device.qubit_set()\n",
"\n",
"# Limit device qubits to only those before row/column `device_limit`\n",

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this qubit_set() use in a notebook -

"\n",
"# Get qubit set\n",
"qubits = device.qubit_set()\n",
"\n",
"# Limit device qubits to only those before row/column `device_limit`\n",

@MichaelBroughton
Copy link
Collaborator Author

Ahhhh that's a good catch Pavol! When I went back to try and fix that tutorial I ran into a lot of problems, after fixing the use of XmonDevice and qubit_set I also saw that none of our QCS devices are calibrated with ISWAP anymore and even worse none of them are reporting two qubit metrics we can use for XEB. Perhaps we should merge this now and open an issue to fix up this tutorial seperately (it is currently in a pretty broken state). WDYT ?

@pavoljuhas
Copy link
Collaborator

Sure, sounds good. I was hoping it would be a one-word change, but if it is a bigger beast it should have its own PR.

@pavoljuhas pavoljuhas self-requested a review June 23, 2022 16:38
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 23, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 23, 2022
@CirqBot CirqBot merged commit eb2a1dc into quantumlib:master Jun 23, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants