-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove deprecated qubits in contrib graphdevice. #5582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Perhaps this one needs to be replaces with Cirq/docs/tutorials/google/identifying_hardware_changes.ipynb Lines 286 to 290 in 640ef8f
|
pavoljuhas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check this qubit_set() use in a notebook -
Cirq/docs/tutorials/google/identifying_hardware_changes.ipynb
Lines 286 to 290 in 640ef8f
| "\n", | |
| "# Get qubit set\n", | |
| "qubits = device.qubit_set()\n", | |
| "\n", | |
| "# Limit device qubits to only those before row/column `device_limit`\n", |
|
Ahhhh that's a good catch Pavol! When I went back to try and fix that tutorial I ran into a lot of problems, after fixing the use of |
|
Sure, sounds good. I was hoping it would be a one-word change, but if it is a bigger beast it should have its own PR. |
pavoljuhas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.