Serializers deprecation #5589
Merged
Serializers deprecation #5589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verult
requested review from
a team,
cduck,
vtomole and
wcourtney
as code owners
dstrain115
approved these changes
Jun 24, 2022
Collaborator
dstrain115
left a comment
dstrain115
left a comment
There was a problem hiding this comment.
LGTM, minus two small comments.
| gate.id = gate_id | ||
|
|
||
| if not isinstance(serializer, op_serializer.GateOpSerializer): | ||
| if not isinstance(serializer, op_serializer._GateOpSerializer): |
Collaborator
There was a problem hiding this comment.
This needs to handle both GateOpSerializer and _GateOpSerilalzer, right?
Collaborator
Author
There was a problem hiding this comment.
_GateOpSerializer is a superclass of GateOpSerializer so both are handled
Collaborator
Author
|
Thanks for the review, merging now. |
verult
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
This PR deprecates all serializers we plan to deprecate * Deprecated GateOpSerializer, GateOpDeserializer, DeserializingArg, and SerializingArg using the class wrapper technique. * CircuitSerializer and serializer classes it depends on (`CircuitOp[De]Serializer`, `Serializer`) are left in place. * Skipping deprecation of common serializers in `common_serializers.py` for now and remove them directly after the 0.15 release as it's very unlikely for users to access them directly. Most users interact with them via global gatesets, e.g. https://github.com/quantumlib/Cirq/blob/abfc619bfe31e93573993c76cecfddc5689dea9b/cirq-google/cirq_google/serialization/gate_sets.py#L43-L64 But if time allows, I'll try to deprecate common serializers as well. * Added mentions of serializer deprecations in global gateset deprecation warnings. @dstrain115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates all serializers we plan to deprecate
CircuitOp[De]Serializer,Serializer) are left in place.common_serializers.pyfor now and remove them directly after the 0.15 release as it's very unlikely for users to access them directly. Most users interact with them via global gatesets, e.g.Cirq/cirq-google/cirq_google/serialization/gate_sets.py
Lines 43 to 64 in abfc619
But if time allows, I'll try to deprecate common serializers as well.
@dstrain115