Skip to content

PauliString and MutablePauliString docs and inconsistencies fixes #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 27, 2022
Merged

PauliString and MutablePauliString docs and inconsistencies fixes #5621

merged 6 commits into from
Jun 27, 2022

Conversation

@tanujkhattar
Copy link
Collaborator

@tanujkhattar tanujkhattar commented Jun 25, 2022

Fixes #5572
Part of #5352

@tanujkhattar tanujkhattar requested review from a team, cduck and vtomole as code owners June 25, 2022 00:35
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jun 25, 2022
dabacon
dabacon requested changes Jun 25, 2022
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the doc strings should move?

@tanujkhattar
Copy link
Collaborator Author

tanujkhattar commented Jun 25, 2022

@dabacon This is ready for a re-review. PTAL!

@tanujkhattar tanujkhattar requested a review from dabacon June 25, 2022 01:43
@tanujkhattar tanujkhattar changed the title PauliString and DensePauliString docs and inconsistencies fixes PauliString and MutablePauliString docs and inconsistencies fixes Jun 25, 2022
dabacon
dabacon approved these changes Jun 26, 2022
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one optional comment.

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 27, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 27, 2022
@CirqBot CirqBot merged commit d7dcd25 into master Jun 27, 2022
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 27, 2022
@CirqBot CirqBot deleted the pauli_string_document branch June 27, 2022 17:30
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 27, 2022
@95-martin-orion 95-martin-orion mentioned this pull request Sep 27, 2022
Merged
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
PauliString and MutablePauliString docs and inconsistencies fixes (…
56f66d7 
…quantumlib#5621)

Fixes quantumlib#5572
Part of quantumlib#5352
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
PauliString and MutablePauliString docs and inconsistencies fixes (…
f68b69e 
…quantumlib#5621)

Fixes quantumlib#5572
Part of quantumlib#5352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dabacon dabacon dabacon approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@95-martin-orion 95-martin-orion Awaiting requested review from 95-martin-orion 95-martin-orion was automatically assigned from quantumlib/cirq-maintainers

Assignees

@dabacon dabacon

Labels

size: M 50< lines changed <250

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cirq.MutablePauliString supports identity gates but cirq.PauliString doesn't, which leads to inconsistencies

3 participants

@tanujkhattar @dabacon @CirqBot