pylint - fail for unnecessary pylint-disable comments#7857
Merged
pavoljuhas merged 1 commit intoquantumlib:mainfrom Jan 27, 2026
Merged
Conversation
By default pylint only reports on `useless-suppression` instances and does not return an error exit code. Here we make it to fail so that useless-suppression-s are caught by the CI. Ref: https://pylint.readthedocs.io/en/stable/user_guide/messages/information/useless-suppression.html
Collaborator
Author
|
Example (should have failed): https://github.com/quantumlib/Cirq/actions/runs/21313354358/job/61544383779#step:7:14 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7857 +/- ##
=======================================
Coverage 99.56% 99.57%
=======================================
Files 1104 1104
Lines 99013 99013
=======================================
+ Hits 98583 98591 +8
+ Misses 430 422 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default pylint only reports on
useless-suppressioninstances,but does not return an error exit code. Here we make it exit with
failure so that useless-suppression-s are caught by the CI.
Ref: https://pylint.readthedocs.io/en/stable/user_guide/messages/information/useless-suppression.html