Clean up recent changes in sub_state_vector#8081
Merged
Merged
Conversation
In `sub_state_vector` use the same tolerance check as was there before with `approx_eq` which has rtol=0. Also verify the maximum eigenvalue is indeed close to 1.
Allow using `None` as a fallback return value of `sub_state_vector`.
Restore behavior as before quantumlib#8077. Also drop duplicate variable.
NoureldinYosri
approved these changes
May 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8081 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 1110 1110
Lines 100074 100074
=======================================
Hits 99712 99712
Misses 362 362 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify the maximum eigenvalue is indeed close to 1.
Enable arbitrary order of
keep_indicesas before.Use the same tolerance check as before Sub state vector #8077 with rtol=0.
This allows to restore previous tests instead of having
to do them with larger state vector deviation.
Put back RaiseValueErrorIfNotProvided as a default for
sub_state_vector.This allows using
Nonefor the fallback return value.Add check for negative values in
keep_indices.Follow-up to #8077