Skip to content

Revise .editorconfig#1334

Merged
mhucka merged 2 commits into
quantumlib:mainfrom
mhucka:revamp-editorconfig
Jun 4, 2026
Merged

Revise .editorconfig#1334
mhucka merged 2 commits into
quantumlib:mainfrom
mhucka:revamp-editorconfig

Conversation

@mhucka

@mhucka mhucka commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

This overhauls the .editorconfig file:

  • Flip the way indent sizes are specified: use a global default of indent_size, and only list exceptions for different file types, instead of having no global default and needing to specify a value for every file type present in the repo. This simplifies the file and is more maintainable.

  • Add entries for some .git/ files such as COMMIT_EDITMSG.

  • Streamline comments.

This overhauls the `.editorconfig`:

* Flip the way indent sizes are specified: use a global default of
  `indent_size`, and only list exceptions for different file types,
  instead of having no global default and needing to specify a value for
  every file type present in the repo.

* Add entries for some `.git/` files such as `COMMIT_EDITMSG`.

* Streamline comments.
@mhucka
mhucka marked this pull request as ready for review June 3, 2026 17:30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the .editorconfig file by establishing a global default indentation size of 4 and removing redundant language-specific overrides. However, removing the overrides for C++ ([{*.cc,*.h}]) and reStructuredText ([*.rst]) files inadvertently changes their indentation settings from 2 and 3 to the new default of 4. It is recommended to retain these specific exceptions to maintain functional equivalence with the original configuration.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .editorconfig
@mhucka
mhucka requested a review from arettig June 3, 2026 18:17

@arettig arettig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much cleaner!

@mhucka
mhucka added this pull request to the merge queue Jun 4, 2026
Merged via the queue into quantumlib:main with commit efaadae Jun 4, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants