Conversation
* origin/master: Adding comment about checking for flag pass completion Adding comments about execution hanging to transfer complete waits Removing default parameter settings Updating DAC SPI structures to own HAL SPI structure for safety guarantees Moving constants to a new file Removing copy to DAC buffers, adding in-place borrow of output buffers Marking AXISRAM as NOLOAD Refactoring timer channels to macros, adding safety notes Adding DMA support for DAC writes Adding sampling_timer file Adding compile-time management of TIM2 channels Reverting changeset Adding documentation Reverting openocd change Adding updated docs for adc file Combining ADC + DAC ISRs Adding WIP updates Formatting Adding ADC/DAC modules Adding WIP updates to using DMA
Member
Author
|
@ryan-summers could you review and give it a quick test on hardware (see whether it behaves as it did before passing through your 1 kHz test signal -> ADC -> DAC -> scope)? |
jordens
force-pushed
the
feature/iir-tweaks
branch
from
a8bee31 to
4689296
Compare
Member
|
@jordens Programming this branch onto a stabilizer with a 1KHz 1V amplitude sinusoid into ADC0 shows an identical sinusoid on DAC0 output. I don't see any distortion or inconsistencies introduced as a result of these changes. I also ran the |
ryan-summers
suggested changes
Nov 30, 2020
Member
ryan-summers
left a comment
ryan-summers
left a comment
There was a problem hiding this comment.
Minor documentation request - was very confused about why we were enabling ARMv8 features until I did a deep dive in documentation and LLVM reviews.
* origin/master: more nightly clippy lints clippy lints gha: clippy-check build(deps): bump paste from 1.0.2 to 1.0.3 build(deps): bump panic-semihosting from 0.5.4 to 0.5.6
Member
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor IIR tweaks and a couple more relevant compiler flags.
Untested on hardware.