DAC initialization update to fix random pulses on power cycle#453
Merged
bors[bot] merged 4 commits intoquartiq:masterfrom Oct 13, 2021
Merged
Conversation
jordens
reviewed
Oct 12, 2021
jordens
reviewed
Oct 12, 2021
jordens
approved these changes
Oct 12, 2021
Member
jordens
left a comment
jordens
left a comment
There was a problem hiding this comment.
Ok.
Run cargo fmt --all over it to make the style checker happy and this is good to go.
Member
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #447 reports random pulses on the DAC outputs after a soft or hard reset.
This can be fixed by using different initial DAC output buffer values on stabilizer and cycling the !CLR pin of the DAC.
Note: this software patch also needs some hardware modifications to work (adding pullups on DAC !LDAC pins, see #447)