Adding runtime settings initial load from flash#857
Merged
Conversation
ryan-summers
commented
Mar 25, 2024
Merged
jordens
reviewed
Mar 25, 2024
Member
|
And it needs good docs about the constraints (only initial settings, don't change |
Member
Author
The broker and ID are not exposed via the MQTT interface, but I'll write docs around the USB interface being initial settings values. |
jordens
requested changes
Mar 26, 2024
jordens
reviewed
Mar 27, 2024
jordens
approved these changes
Mar 27, 2024
Member
jordens
left a comment
jordens
left a comment
There was a problem hiding this comment.
Apart from #857 (review)
good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #822 by adding support for modifying the runtime settings and persisting them to flash via the USB interface.
This should be merged after: