Merged
Conversation
jordens
previously approved these changes
Jun 21, 2024
jordens
previously approved these changes
Jun 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions
bot
added
the
changes-hitl
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #887 by updating the logic of
data_stream.rs. Thesmoltcp-nalis also bumped, but we should likely just release it as a 0.5.1 and update it here.I also refactored how the
stream_targetis stored. It now gets serde'd as the string form, i.e.192.168.1.1:1234Release PR is in quartiq/smoltcp-nal#51
I verified this was fixed by updating my stream_target internally and rebooting Stabilizer.