Skip to content

preview: update consumers for shared FCS and PDF changes#4859

Open
Austin-s-h wants to merge 31 commits into
quiltdata:preview-lambda-sharedfrom
Austin-s-h:preview-lambda-consumers
Open

preview: update consumers for shared FCS and PDF changes#4859
Austin-s-h wants to merge 31 commits into
quiltdata:preview-lambda-sharedfrom
Austin-s-h:preview-lambda-consumers

Conversation

@Austin-s-h
Copy link
Copy Markdown
Collaborator

@Austin-s-h Austin-s-h commented Apr 26, 2026

Summary

Update consumer lambdas to use the new shared FCS parsing layer from #4858, plus PDF preview refactor sharing the same lambda base.

Affected lambdas

  • lambdas/indexer/ — index FCS metadata
  • lambdas/preview/ — render FCS preview with new vegaLite field
  • lambdas/tabular_preview/ — minor adjustments
  • lambdas/thumbnail/ — PDF refactor + FCS-aware thumbnails

Stack relationship

This PR is stacked on top of #4858 (rebase-based). Until #4858 lands on master, this PR's diff against master will include the shared-layer changes from #4858; review the diff in that lens, or review #4858 first.

PR Layer
#4858 Shared lambda parsing + vegaLite spec
#4859 (this) Consumer lambdas updated to use shared layer
#4860 Catalog frontend Vega chart rendering

Validation

  • cd lambdas/<consumer> && uv run pytest
  • End-to-end FCS file preview smoke (deployment-side)

Deployment context

Tracked in deployment#2395; rolled out via deployment#2394.

@Austin-s-h Austin-s-h mentioned this pull request Apr 26, 2026
8 tasks
Comment thread lambdas/shared/src/t4_lambda_shared/preview.py Outdated
Comment thread lambdas/shared/src/t4_lambda_shared/preview.py
drernie added a commit that referenced this pull request Apr 27, 2026
Austin's #4859 bumped indexer's pyproject + uv.lock to ==3.13.* but left
the Dockerfile on the python:3.12 lambda base, causing uv sync to fail
with "No interpreter found for Python ==3.13.*".

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 99.43820% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.95%. Comparing base (cea497e) to head (d789f0b).

Files with missing lines Patch % Lines
lambdas/thumbnail/tests/test_thumbnail.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4859      +/-   ##
==========================================
+ Coverage   45.69%   45.95%   +0.25%     
==========================================
  Files         829      830       +1     
  Lines       33532    33694     +162     
  Branches     5698     5698              
==========================================
+ Hits        15323    15484     +161     
- Misses      16212    16213       +1     
  Partials     1997     1997              
Flag Coverage Δ
api-python 93.14% <ø> (ø)
catalog 19.55% <ø> (ø)
lambda 96.79% <99.43%> (+0.16%) ⬆️
py-shared 98.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@drernie drernie force-pushed the preview-lambda-consumers branch from 7e2daf5 to b170004 Compare April 28, 2026 00:46
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@drernie drernie force-pushed the preview-lambda-consumers branch from b170004 to d789f0b Compare April 28, 2026 03:03
@drernie
Copy link
Copy Markdown
Member

drernie commented Apr 28, 2026

@Austin-s-h heads-up — your consumer-update branch has been rebased on top of #4858 so it inherits all the latest shared-layer fixes (Greptile P1+P2, Copilot's empty-token / numpy.isfinite / memory refactor / py-shared cleanup).

What changed on austin/preview-lambda-consumers

  • Rebased onto austin/preview-lambda-shared (instead of plain master). Your single consumer commit e9463158 is now on top of the post-fix shared-layer state.
  • No content changes to the consumer lambdas themselves — just rebase.

Stack relationship
This PR is now stacked on #4858. Until #4858 lands on master, this PR's diff against master will include the shared-layer changes from #4858; review the diff in that lens, or review #4858 first.

Status

  • CI: ✅ all 44 checks green
  • Copilot review errored twice (Copilot-side issue, not your code) — could retry manually via the GitHub UI
  • Mergeable, awaiting human review

(Note: Copilot reviewed #4858 successfully but errored on this one and on #4860 — appears to be flaky on GitHub's side, not anything wrong with the PRs.)

nl0 and others added 5 commits April 29, 2026 18:30
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Dr. Ernie Prabhakar <ernest@quilt.bio>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Maksim Chervonnyi <mail@redmax.dev>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Sergey Fedoseev <fedoseev.sergey@quiltdata.io>
@drernie drernie changed the base branch from master to preview-lambda-shared May 1, 2026 21:35
drernie and others added 9 commits May 7, 2026 01:40
…a#4879)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…iltdata#4886)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…4882)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…4877)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…view (quiltdata#4898)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…iltdata#4897)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ltdata#4896)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot Bot and others added 11 commits May 12, 2026 10:40
…uiltdata#4895)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dexer (quiltdata#4894)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…iltdata#4893)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rts (quiltdata#4892)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…iltdata#4891)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…uiltdata#4890)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…iltdata#4889)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexei Mochalov <nl_0@quiltdata.io>
…uiltdata#4899)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…uiltdata#4900)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants