Treat TinyTDS failed dbsqlsend() errors as ConnectionNotEstablished - #1393
Merged
aidanharan merged 1 commit intoJul 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TinyTDS can raise
failed dbsqlsend() functionwhen the underlying FreeTDS socket has dropped. This happens when an idle connection gets reaped by network infrastructure or by SQL Server itself.translate_exceptiondoesn't recognize this message right now, so it falls through toStatementInvalid. ActiveRecord's connection pool doesn't treat that as reconnectable, so callers get a hard query failure instead of a transparent reconnect and retry.This is the same failure mode already handled for
"SQL Server client is not connected"and"failed to execute statement". I addedfailed dbsqlsendto that same pattern so it maps toActiveRecord::ConnectionNotEstablishedtoo.