Don't fire ajax:send if ajax:beforeSend was cancelled. Don't disable form elements until ajax:send. #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ajax:sendevent if anajax:beforeSendevent-handler cancels the AJAX request (viareturn false). Currently, it's lying to us because you would still see anajax:sendevent even if no request was made. This will make it honest by only firingajax:sendif a request was actually heading to the server.ajax:sendevent fires. Currently, it disables form elements when theajax:beforeSendevent bubbles up to the document. So if you had your own document-levelajax:beforeSendevent-handler that was bound after the one fromjquery_ujs.js, your form elements would still get disabled, even if you cancelled the AJAX request by doingreturn falsefrom your event-handler. This will wait to disable the form elements until we're sure that an AJAX request is actually being made, by hooking into theajax:sendevent.