Skip to content

Conversation

@lsylvester
Copy link
Contributor

#34012 added an alias to to except for HashWithIndiferentAccess, but the except method comes from a core extension which may not have been required.

The PR adds a require for the except method so that it is always available for aliasing.

Should fix some build issues with #33079.

@rails-bot
Copy link

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

@TomaszGrudzinski
Copy link

If that alias is truly needed (I don't believe it is), it should be moved to the active_support/core_ext/hash/except.rb file so that the except method would always be defined.

@y-yagi
Copy link
Member

y-yagi commented Sep 30, 2018

This does not happen if active_support is required first, so it seems that there is no error in the test of the master branch.
That is because it requires active_support/core_ext/hash/except at i18n.rb.
I think that it is not good to rely on this, and I think that dependent libraries should be required in that file.

@y-yagi y-yagi merged commit 09f92a1 into rails:master Sep 30, 2018
@y-yagi
Copy link
Member

y-yagi commented Sep 30, 2018

@lsylvester Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants