Conversation
|
Reviews in this chain: |
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with Bazel 7+ where java_test targets no longer produce a _deploy.jar file. The solution is to introduce a companion java_binary target, all_tests_bin, which generates the required all_tests_bin_deploy.jar. All references have been updated accordingly. The changes are correct and address the problem described. I've added one comment regarding code duplication between the new java_binary and the existing java_test target, suggesting a refactoring to improve maintainability.
d63555f to
636fcd7
Compare
396daf4 to
9f0e1ca
Compare
636fcd7 to
076937e
Compare
076937e to
df80fe6
Compare
…ests
java_test targets do not produce a _deploy.jar in Bazel 7+. Add a companion
java_binary (all_tests_bin) that produces all_tests_bin_deploy.jar in both
Bazel 6 and Bazel 7, and update all references accordingly.
The java_binary includes //cpp:counter.so and //cpp:plus.so as resources so
that CrossLanguageInvocationTest.getResourceAsStream("/cpp/counter.so") finds
them in the deploy jar classpath.
Topic: java-all-tests-bin-deploy-jar
Relative: macos-raylet-dynamic-lookup
Signed-off-by: andrew <andrew@anyscale.com>
df80fe6 to
23649dd
Compare
java_test targets do not produce a _deploy.jar in Bazel 7+. Add a companion
java_binary (all_tests_bin) that produces all_tests_bin_deploy.jar in both
Bazel 6 and Bazel 7, and update all references accordingly.
The java_binary includes //cpp:counter.so and //cpp:plus.so as resources so
that CrossLanguageInvocationTest.getResourceAsStream("/cpp/counter.so") finds
them in the deploy jar classpath.
Topic: java-all-tests-bin-deploy-jar
Relative: macos-raylet-dynamic-lookup
Signed-off-by: andrew andrew@anyscale.com