[Build] Replace rules_boost lzma patches with a custom org_lzma_lzma build file

[andrew-anyscale]

Instead of patching rules_boost's BUILD.lzma at dependency-resolution time,
declare org_lzma_lzma before com_github_nelhage_rules_boost so that
boost_deps()'s maybe() skips it. A local build_file label
(//thirdparty/patches:org_lzma_lzma.BUILD.bazel) forces content-based cache
invalidation: changing the file triggers re-setup on all machines, including
Windows CI with a persistent output base where patching an external repo's
BUILD file in-place would not propagate to already-extracted directories.

The custom build file also fixes Windows MSVC D8004 by using -Ipath copts
(no space between -I and the path) and replaces the includes attribute with
strip_include_prefix for more reliable include path handling.

Topic: lzma-custom-build-file
Relative: java-all-tests-bin-deploy-jar
Signed-off-by: andrew andrew@anyscale.com

[andrew-anyscale]

Reviews in this chain:
└#61669 [Build] Replace rules_boost lzma patches with a custom org_lzma_lzma build file
　└#61694 [Build] Patch protobuf for Bazel 7 exec_tools removal
　　└#61695 [Build] Upgrade rules_apple/apple_support and set macOS toolchain flags for Bazel 7
　　　└#61601 [Build] Upgrade Bazel from 6.5.0 to 7.5.0
　　　　└#61725 [Build] Upgrade protobuf 28.2, absl 20240722.0, grpc 1.68.2, boringssl

[andrew-anyscale]

#	head	base	diff	date	summary
0	a6fec9ca	d63555fd	diff	Mar 11 16:07 PM	2 files changed, 208 insertions(+)
1	d2029f77	636fcd7b	diff	Mar 12 11:49 AM	1 file changed, 14 insertions(+), 7 deletions(-)
2	f63c28fd	076937ea	diff	Mar 12 12:31 PM	0 files changed
3	c8e84390	076937ea	diff	Mar 12 12:49 PM	1 file changed, 7 insertions(+), 40 deletions(-)
4	4b62149c	df80fe60	rebase	Mar 12 20:31 PM	0 files changed
5	be1c72d1	23649dd4	rebase	Mar 13 11:13 AM	0 files changed
6	5c8b5467	23649dd4	diff	Mar 13 14:43 PM	1 file changed, 6 insertions(+), 56 deletions(-)
7	83fffee6	23649dd4	diff	Mar 13 17:26 PM	2 files changed, 28 insertions(+), 43 deletions(-)
8	f3190a02	ae7ad50c	diff	Mar 13 17:27 PM	0 files changed

[gemini-code-assist]

Code Review

This pull request replaces the patching of rules_boost's lzma build file with a custom build file for org_lzma_lzma. This is a solid approach to improve build reliability and cacheability, especially on Windows. The changes are well-explained in the pull request description and in the code comments. I have one suggestion for the new BUILD file to improve its maintainability by avoiding a hardcoded repository name.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[aslonnie]

should these be using glob?

[andrew-anyscale]

Glob'd what I could. Some cannot be without pulling in files we do not want

[aslonnie]

hmm.. which files are ones we do not want?

[andrew-anyscale]

Mix of "causes linker errors", others are just hygeine.

1. src/xz/, src/xzdec/, src/lzmainfo/** + the *_tablegen.c files
   These all define main(). Including them in a cc_library produces a link error (multiple definition of
   main) for any binary that depends on :lzma.

2. crc32_small.c and crc64_small.c
   Both define the same symbols as crc32_fast.c and crc64_fast.c (lzma_crc32, lzma_crc64). Including both is
   a link error — duplicate symbol at link time.

3. The five tuklib_*.c CLI utility files (tuklib_exit.c, tuklib_mbstr_fw.c, etc.)
   These don't have main() and don't conflict with anything in the library. Worst case: dead code in the
   archive, and they may pull in CLI-only headers that don't compile cleanly on all platforms. Probably
   harmless in practice, but formally wrong.

[aslonnie]

these also seems glob-able?

[aslonnie]

maybe exclude api headers? those api header files are double included now?

[aslonnie]

hmm.. which files are ones we do not want?