Conversation
Contributor
Author
|
Reviews in this chain: |
Contributor
Author
|
This was referenced Mar 12, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades rules_apple and apple_support to versions compatible with Bazel 7, and includes a patch to handle environments with only Xcode Command Line Tools installed. The changes are well-explained and appear correct. I've suggested a minor improvement for maintainability by using constants for versions and hashes in ray_deps_setup.bzl.
a8f15f8 to
899eb2e
Compare
6b48a59 to
ef49837
Compare
899eb2e to
abcb022
Compare
abcb022 to
e74b48d
Compare
1030fdc to
a99eab4
Compare
e74b48d to
5114f87
Compare
This was referenced Mar 13, 2026
a99eab4 to
4134a22
Compare
4b75378 to
bc015e0
Compare
e5f8806 to
ca0a317
Compare
bc015e0 to
8883f3c
Compare
Bazel 7 removed the exec_tools attribute from genrule; patch protobuf's BUILD files to use tools instead. Topic: protobuf-bazel7-exec-tools Relative: lzma-custom-build-file Signed-off-by: andrew <andrew@anyscale.com>
…gs for Bazel 7 gRPC's grpc_deps() pulls in rules_apple 1.1.3 which uses apple_common.multi_arch_split, removed in Bazel 7. Override to 3.2.1 (compatible with Bazel 6/7/8) before grpc_deps() runs so the maybe() call is a no-op. rules_apple 3.2.1 requires apple_support >= 1.11.1. Patch is_xcode_at_least_version to return False instead of fail() on CLT-only CI machines where xcode_config.xcode_version() is None. Set BAZEL_NO_APPLE_CPP_TOOLCHAIN=1 to skip apple_cc_toolchain on CLT-only machines where it would fail with "Xcode version must be specified". Override -mmacosx-version-min to 12.0 to satisfy std::filesystem and std::variant requirements (generic toolchain defaults to 10.11). Topic: macos-apple-toolchain-bazel7 Relative: protobuf-bazel7-exec-tools Signed-off-by: andrew <andrew@anyscale.com>
ca0a317 to
871d61e
Compare
8883f3c to
23fb31c
Compare
Base automatically changed from
andrew/revup/master/protobuf-bazel7-exec-tools
to
master
March 16, 2026 17:59
aslonnie
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC's grpc_deps() pulls in rules_apple 1.1.3 which uses
apple_common.multi_arch_split, removed in Bazel 7. Override to 3.2.1
(compatible with Bazel 6/7/8) before grpc_deps() runs so the maybe()
call is a no-op.
rules_apple 3.2.1 requires apple_support >= 1.11.1. Patch
is_xcode_at_least_version to return False instead of fail() on
CLT-only CI machines where xcode_config.xcode_version() is None.
Set BAZEL_NO_APPLE_CPP_TOOLCHAIN=1 to skip apple_cc_toolchain on
CLT-only machines where it would fail with "Xcode version must be
specified". Override -mmacosx-version-min to 12.0 to satisfy
std::filesystem and std::variant requirements (generic toolchain
defaults to 10.11).
Topic: macos-apple-toolchain-bazel7
Relative: protobuf-bazel7-exec-tools
Signed-off-by: andrew andrew@anyscale.com