[rmodels] Fix memory leak in UnloadModel() - #5907
Merged
Merged
Conversation
Owner
|
@LuisR385 thanks for the review! |
serveraddressesonion-lgtm
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a memory leak in
UnloadModel()when loading and unloading 3D models with bones (skinned models).LoadModel()allocates memory formodel.currentPoseandmodel.boneMatrices, butUnloadModel()does not free them.Scope of leak
Tested with a GLB model containing 43 bones on raylib 6.0 (Windows / Visual Studio).
Leak sizes reported by Visual Studio exactly match the bone allocations:
Solution
Added
RL_FREE(model.currentPose);andRL_FREE(model.boneMatrices);insideUnloadModel()right before the TRACELOG.The
RL_FREEmacro safely checks forNULL, so this will not cause any issues or crashes for non-animated models (models without bones).