refactor: use shared non-nullable guards - #397
Conversation
|
@QDyanbing is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. Walkthrough项目升级 ChangesStep 非空判断工具更新
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change replaces duplicated null and undefined checks in Step rendering with the shared utility and updates its required dependency version. Title, subtitle, and content rendering behavior remains unchanged, with no current merge-readiness risk identified. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 99 97 -2
Branches 38 36 -2
=========================================
- Hits 99 97 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
说明
isNonNullable替换 title、subTitle 和 content 的本地hasContent判断@rc-component/util的最低版本提升到^1.13.0验证
npm run tscnpm run lintnpm test -- tests/index.test.tsx --runInBandSummary by CodeRabbit