Skip to content

PUBLIC_URL is not the same as homepage, but only the pathname #8813

Description

@elvisLAI

Describe the bug

I have uploaded all the static resources to CDN, include .js and .css files. So I have to set the 'homepage' as the host address of CDN server, which make the urls of scripts in 'index.html' to be right.

However, the urls injected to 'index.html' is the pathname of 'homepage' that I set in package.json, after upload react-scripts to 3.4.1.

And there is no such problem when I using version 3.3.0. I found that the actual homepage has been change after this PR feat(react-scripts): allow PUBLIC_URL in develoment mode

So I want to know, is it a bug that will be fixed? Or is there any method that can make the PUBLIC_URL to be a complete url.

Did you try recovering your dependencies?

no, but downgrade to 3.3.0

Which terms did you search for in User Guide?

The docs still use the complete url as example Step 1: Add homepage to package.json

Environment

irrelevant, i guess

Steps to reproduce

(Write your steps here:)

  1. set homepage in package.json like 'https://example.com/a/b/c'
  2. yarn build
  3. the url of script in index.html will be '/a/b/c/xxx.js', which will not find the correct resource

Expected behavior

The PUBLIC_URL should be the same as homepage in package.json

Actual behavior

The PUBLIC_URL is the pathname of homepage

Reproducible demo

no demo

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions