Skip to content

Fix incorrect glob pattern in webpack config#11875

Open
amatissart wants to merge 1 commit into
react:mainfrom
amatissart:fix-webpack-config-glob
Open

Fix incorrect glob pattern in webpack config#11875
amatissart wants to merge 1 commit into
react:mainfrom
amatissart:fix-webpack-config-glob

Conversation

@amatissart
Copy link
Copy Markdown

After upgrading to react-scripts v5, we noticed unexpected Typescript errors related to test files when running the dev server.

It seems that one of the "exclude" rules has not been adapted correctly during the upgrade in #11201

@facebook-github-bot
Copy link
Copy Markdown

Hi @amatissart!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@heuperman
Copy link
Copy Markdown

I ran into this bug recently and as this PR seems to have been overlooked I've opened issue
#12453 for it in the hope of getting it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants