fix: webpack hanging under certain circumstance, use process.exitCode…#12292
fix: webpack hanging under certain circumstance, use process.exitCode…#12292alexxyzeng wants to merge 1 commit into
Conversation
… = 1 instead of process.exit(1)
|
Hi @alexxyzeng! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
sometimes i found out


react-scripts buldhangs under certain circumstances, like:when i changed process.exit(1) to process.exitCode = 1, it can end up with failure:
According to https://nodejs.org/dist/latest-v16.x/docs/api/process.html#processexitcode_1:
I also find that
webpackandwebpack-clialso have simlar issues fixed:fix: fix webpack hanging under certain circumstance
Fix webpack hanging under certain circumstance, use process.exitCode instead of process.exit in compilerCallback
misc(refactor): reduce code duplication use process.exitCode instead of process.exit