Update proxying-api-requests-in-development.md - #8429
Open
chybisov wants to merge 2 commits into
Open
Conversation
We should always pass path parameter to app.use and context parameter to proxy, which are almost always the same, except cases mentioned in third Note. app.use mounts the specified middleware function at the specified path: the middleware function is executed when the base of the requested path matches path. proxy first parameter specify context (part of url) which then will be checked whether request url has it or not. This is not necessarily with http requests, but will break WebpackDevServer sockjs-node HMR functionality when we try to proxy some of our own websocket requests. Default context is '/' and because all urls has '/', /sockjs-node from WDS also will be proxied, but it shouldn't. http requests work without specifying context because no one else sends http requests.
Contributor
Author
|
Updated http-proxy-middleware imports as of v1.0.0 |
amyrlam
removed their request for review
August 24, 2020 05:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should always pass path parameter to
app.useand context parameter toproxy, which are almost always the same, except cases mentioned in third Note.app.usemounts the specified middleware function at the specified path: the middleware function is executed when the base of the requested path matches path.proxyfirst parameter specify context (part of url) which then will be checked whether request url has it or not. This is not necessarily with http requests, but will breakWebpackDevServersockjs-nodeHMR functionality when we try to proxy some of our own websocket requests. Default context is'/'and because all urls has'/',/sockjs-nodefromWDSalso will be proxied, but it shouldn't. http requests work without specifying context because no one else sends http requests.Related to this comment.