Bump Hermes to 0.7.2 for v0.64#30561
Conversation
https://github.com/facebook/hermes/releases/tag/v0.7.2 is out so we can bump the pod version 🎉 Question: Is `~> 0.7.2` too strict? Would `>= 0.7.2` be better? Also, It doesn't look like we are restricting any version on the trunk?
I think keeping it is good, e.g. the JSI ABI differences thus far have meant that RN versions can't just take in any Hermes version, so locking it to patch versions equal to or higher than 0.7.2 seems good 👍
Can you elaborate on what you’re referring to by this? |
|
@alloy I just have another look at https://guides.cocoapods.org/using/the-podfile.html and realize everything was good :)
I misunderstood
Yeah I mean we did not specify a version at the master branch, which actually means it will always take the latest, which is also what we want ;) |
|
Just curious if this was intentional or a mistake that this PR was opened against release branch and didn't land on master? In such case, it may need to be synced once again. |
|
@grabbou it was intentional since I observed that they are already not synced: we specified But quoting my later realization:
which seems to be what we want? |
Summary
https://github.com/facebook/hermes/releases/tag/v0.7.2 is out so we can bump the pod version 🎉
Question:
Is
~> 0.7.2too strict? Would>= 0.7.2be better?Also, It doesn't look like we are restricting any version on the trunk?
Changelog
[INTERNAL] - Bump Hermes version
Test Plan
Quoting from facebook/hermes#373