WIP: Add Stripe Payments Intents API SCA-compliant Payment Component (Not intended for merge right now) #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com>
…bot/npm_and_yarn/elliptic-6.5.4 chore(deps): Bump elliptic from 6.5.3 to 6.5.4
Signed-off-by: Josh Habdas <jhabdas@protonmail.com>
Signed-off-by: Josh Habdas <jhabdas@protonmail.com>
feat: add typescript support
BREAKING CHANGE: the authorization methods have been switched to account-js Signed-off-by: Akarshit Wal <akarshitwal@gmail.com>
…t-feat-account-js-auth feat: use account-js for authentication
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/npm/ssri/releases) - [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md) - [Commits](npm/ssri@v6.0.1...v6.0.2) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.21 to 0.7.28. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Commits](faisalman/ua-parser-js@0.7.21...0.7.28) Signed-off-by: dependabot[bot] <support@github.com>
…bot/npm_and_yarn/ua-parser-js-0.7.28 chore(deps): Bump ua-parser-js from 0.7.21 to 0.7.28
…bot/npm_and_yarn/ssri-6.0.2 chore(deps): Bump ssri from 6.0.1 to 6.0.2
…bot/npm_and_yarn/y18n-3.2.2 chore(deps): Bump y18n from 3.2.1 to 3.2.2
Signed-off-by: Janus Reith <mail@janusreith.de>
Contributor
|
merging to another branch in order to fix lint stuff |
Collaborator
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janus Reith mail@janusreith.de
Resolves #5304
Impact: breaking|major
Type: feature|refactor
Issue
The new Stripe Payment api plugin would not be compatible with the existing stripe frontend integration.
Solution
This PR adds a new Stripe Credit Card form and utilizes the new mutation to create a Stripe payment intent.
Breaking changes
This might replace the existing integration in the default storefront, or live side by side with it.
Removing the existing one might be desired though, since it requires an outdated stripe package to be be bundled, as the old integration is not entirely decoupled in the existing component library.
Testing
See here: reactioncommerce/api-plugin-payments-stripe-sca#2
Notice & Todo
This branch is intended for testing and should not be merged. I envision this payment component to be distributed as separate module which could be imported from the storefront.
A separate PR might get rid of the existing stripe package included in the storefront, one blocker here is the component library currently throwing errors if that package is not present, regardless of its Stripe Payment Form actually being in use.