sort-comp customization

[reergymerej]

It would be nice to pick up the specific sort order defined in .eslintrc if not provided through the CLI options before falling back to the airbnb order.

[cpojer]

cc @lencioni

[lencioni]

This makes sense to me. I'd be happy to review a PR!

[reergymerej]

I'll get on it.

[cpojer]

ping? :)

[reergymerej]

After a cursory glance, I realized this may be more complex than I thought. Pulling in eslint config happens in a variety of ways that I don't want to reinvent. I still think it's a good idea, just not sure how to approach getting the eslint config options smartly.

[cpojer]

Is there an API in eslint that gives you a configuration for a given file?

[reergymerej]

Not one that I found, surprisingly. I'd be happy for someone with more Eslint experience to prove me wrong.

[lencioni]

You can use ESLint to get the config for any given file. Here's an example:

const cli = new eslint.CLIEngine();
const config = cli.getConfigForFile(PATH_TO_FILE);

https://github.com/Galooshi/import-js/blob/dbb69adaff0e4912d9a758e77a9e39cbaf944c03/lib/Importer.js#L102-L103

Docs: http://eslint.org/docs/developer-guide/nodejs-api#getconfigforfile

Although, this might make Jest unhappy: jestjs/jest#1048

[cpojer]

I'll happily fix the Jest issue. @reergymerej can you make this work?

[reergymerej]

@cpojer Yeah, thanks to @lencioni putting me on the right track. Reading the config seems pretty straight-forward, just trying to figure out how best to get it to play nicely with the real lint rules. I'll try and get a PR soon.

[cpojer]

Closing, PR will be merged shortly.