Skip to content

Conversation

@reergymerej
Copy link
Contributor

@reergymerej reergymerej commented May 31, 2016

fixes #44

});

const config = cli.getConfigForFile(filePath);
const { rules } = config;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the spaces here? :)

@cpojer
Copy link
Member

cpojer commented May 31, 2016

this is great!

@reergymerej
Copy link
Contributor Author

Yeah, I'll fix it ASAP.

@reergymerej
Copy link
Contributor Author

I tried to follow the surrounding styles since I didn't see any style guidelines anywhere. Please let me know if this needs to be changed again.

@cpojer cpojer merged commit 72b5fe4 into reactjs:master May 31, 2016
@cpojer
Copy link
Member

cpojer commented May 31, 2016

thank you :)

turadg added a commit to turadg/react-codemod that referenced this pull request May 31, 2016
now observes eslintconfig
@turadg
Copy link
Contributor

turadg commented May 31, 2016

Yay! Here's an update for the README, #49

cpojer added a commit that referenced this pull request May 31, 2016
Update sort-comp doc for #48
@TSMMark
Copy link

TSMMark commented Oct 22, 2017

This is awesome. It would be great to print out any errors that occur during loading of the .eslintrc. I was spending a lot of time trying to figure out why it wasn't honoring my eslintrc and turns out it was erroring on a missing npm module, so it wasn't even loading my eslintrc at all, but I would never know it unless I edit this package source directly on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sort-comp customization

4 participants