[Fixes] #854 Adding a check to see if the element is a prototype of Element before checking computed style #864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #[854] - Issue on Modal Lock when modal contains web component that contains an iframe
Changes proposed:
Adding a check to see if the element is a prototype of Element before checking computed style
The issue is that as the react-modal is cycling through the elements to determine whether they are tabbable, when it comes to cycling through the modal, it goes from inside to out. As it moves from
<iframe id="wiz"> up to the parent node toI was able to confirm that the issue is that when it hits the , this is being returned as a ShadowRoot object, which has no parent and is not supported by the window.getComputedStyle (since it can never have style)
Acceptance Checklist:
CONTRIBUTING.md.