-
Notifications
You must be signed in to change notification settings - Fork 433
Update react-modal from 3.13.1 to 3.14.2 to add bugfix-PR 7e732d7 Wrapping getComputedStyle i… #2895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-modal from 3.13.1 to 3.14.2 to add bugfix-PR 7e732d7 Wrapping getComputedStyle i… #2895
Conversation
|
Thanks for opening this pull request! 💯 This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. TravisCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause TravisCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. |
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Brendan Keogh <b***@b***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated. |
|
Signed the CLA |
|
not sure what is going on here, running the test:unit locally passes and using the storyboard to look at the modals, they look to operate correctly. |
|
First, thank you for the package update. The Mocha-based browser appear to be failing in the CI #2753 I did a check on |
…till searching for the root cause
|
Thanks for the test update. Will review. |
|
Congrats on merging your first pull request to Design System React! 🎉 |



This request is to update the react-modal package to 3.14.2 - the fix this targets is - reactjs/react-modal#864
Fixes #
This fixes an issue where using the slds-modal, and the modal contains an iframe which in turn contains webcomponents, the modal does not lock focus to the modal
Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fixhas been run and linting passes.components/component-docs.jsonCI tests pass (npm test).REVIEWER checklist (do not remove)
components/component-docs.jsontests.Required only if there are markup / UX changes
last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.