fix(analysis): say which component your data hit, so it can be read - #171
Merged
Conversation
Curators, re-testing #154: "the components are shown, but an indication of which component is hit in the analysis is missing." It was not missing. Run against a real tissue analysis -- the HPA experiment through /ExperimentDigester, posted exactly as the Tissue form posts it -- every component row carries a marker: 8 popups, 15 rows, none unmarked, and the found/not-found split matches the data. So the report is about what the panel looks like, and on that it is right. Three things made a present indication unreadable: - **The marker was on its own line.** The row is a column flex, so a 7px dot sat above the name rather than beside it, unattached to anything. - **A hollow dot was the entire signal** for a component your data missed. On a row with no values beside it there was nothing else to read. - **The values were three bare numbers.** Which tissue each belonged to was in a tooltip, and nobody hovers a tooltip to discover a column exists. Now: the dot sits against the name it belongs to, with a ring that separates found from not-found at a glance; a missed row says "not in your data" in words; and each value is a chip carrying its sample's name. Also fixes the emphasis that was supposed to mark the sample the diagram is coloured by, and never once did. `state.sample` holds the column's *name* -- `samples()[index]` is what sets it -- so reading it as a number gave NaN for every real analysis. It only appeared to work when no sample was set, where the fallback was the first column anyway. Verified on beta across all four states: tissue expression (chips, current sample emphasised), overrepresentation (markers, no chips), a component the data missed, and no analysis at all (no marker, no text). Refs #154 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curators, re-testing #154: "the components are shown, but an indication of which component is hit in the analysis is missing."
It was not missing — it was unreadable
Run against a real tissue analysis (the HPA experiment through
/ExperimentDigester, posted exactly as the Tissue form posts it): 8 popups, 15 component rows, 0 without a marker, and the found/not-found split matches the data. So the report is about what the panel looks like — and on that it is right.Three things made a present indication unreadable:
Before / after
The dot now sits against the name it belongs to, with a ring separating found from not-found at a glance; a missed row says not in your data in words; and each value is a chip carrying its sample's name.
And an emphasis that never once worked
The current-sample highlight — "the number you are looking at on the canvas is the one that stands out here" — never fired.
state.sampleholds the column's name (samples()[index]is what sets it), soNumber(...)gaveNaNfor every real analysis. It only appeared to work when no sample was set, where the fallback happened to be the first column anyway. Now the emphasised chip really is the sample the diagram is coloured by.Verified on beta
All four states: tissue expression (chips, current sample emphasised), overrepresentation (markers, no chips, since there are no values), a component the data missed, and no analysis at all (no marker, no text, nothing added).
Refs #154 — leaving it open until curators confirm this is what they meant. The larger reading (drawing components as nodes inside the canvas) is untouched and still needs a deliberate decision.