[CodeQuality] Skip new object instances in NarrowIdenticalWithConsecutiveRector#726
Merged
Merged
Conversation
Member
Author
|
To avoid side-effects, that we found in one project when new statefull class was created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip narrowing
withConsecutive()/willReturnOnConsecutiveCalls()when any consecutive arg builds anewobject.Each
newcall creates a fresh instance, possibly with a property/constructor dependency, so collapsing them to a singlewith()/willReturn()changes intent.$someServiceMock->expects($this->exactly(3)) ->method('prepare') - ->withConsecutive( - [new \stdClass()], - [new \stdClass()], - [new \stdClass()], - ); + ->withConsecutive( + [new \stdClass()], + [new \stdClass()], + [new \stdClass()], + ); // now skipped, left as-isPlain scalar repeats still narrow as before: