[CodeQuality] Skip assertNull/assertEmpty in AssertEmptyNullableObjectToAssertInstanceofRector - #780
Merged
Merged
Conversation
…tToAssertInstanceofRector assertNull/assertEmpty were converted to assertNotInstanceOf, which is no clearer than the original and contradicts the rule's stated goal of narrowing to assertInstanceOf. Keep only the assertNotEmpty/assertNotNull direction. Fixes #9867 Claude-Session: https://claude.ai/code/session_013HSzJq1AksJfqCvf2bX1nk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9867
The rule converted
assertNull()/assertEmpty()on a nullable object intoassertNotInstanceOf(SomeClass::class, ...).For a
SomeClass|nullunion that is logically equivalent, butassertNotInstanceOfis no clearer than the originalassertNull- the opposite of the rule's stated goal ("Change assertNotEmpty() and assertNotNull() on an object to more clear assertInstanceof()"). The rule name and its only code sample also cover just the not-empty/not-null direction.This keeps only the useful narrowing:
assertNotEmpty/assertNotNull->assertInstanceOfand leaves
assertNull/assertEmptyuntouched.