[config] Deprecate and remove @noRector annotation, as not reliable DX choice; use skip() method instead

packages/Parallel/WorkerRunner.php

@@ -93,6 +93,20 @@ public function run(Encoder $encoder, Decoder $decoder, Configuration $configura
                         $errorAndFileDiffs,
                         $currentErrorsAndFileDiffs
                     );
+
+                    // warn about deprecated @noRector annotation
+                    if (! str_ends_with($file->getFilePath(), 'WorkerRunner.php')
+                        && (
+                            str_contains($file->getFileContent(), ' @noRector ') ||
+                            str_contains($file->getFileContent(), ' @norector ')
+                        )
+                    ) {
+                        $systemErrors[] = new SystemError(
+                            'The @noRector annotation was deprecated and removed due to hiding fixed errors. Use more precise $rectorConfig->skip() method in the rector.php config.',
+                            $file->getFilePath()
+                        );
+                        continue;
+                    }
                 } catch (Throwable $throwable) {
                     ++$systemErrorsCount;
                     $systemErrors = $this->collectSystemErrors($systemErrors, $throwable, $filePath);

packages/PhpDocParser/PhpDocParser/ValueObject/Ast/PhpDoc/SimplePhpDocNode.php

@@ -9,10 +9,9 @@
 use PHPStan\PhpDocParser\Ast\Type\TypeNode;
 
 /**
- * @noRector final on purpose, so it can be extended by 3rd party
  * @api
  */
-class SimplePhpDocNode extends PhpDocNode
+final class SimplePhpDocNode extends PhpDocNode
 {
     public function getParam(string $desiredParamName): ?ParamTagValueNode
     {

src/Rector/AbstractRector.php

@@ -25,7 +25,6 @@
 use Rector\Core\Console\Output\RectorOutputStyle;
 use Rector\Core\Contract\Rector\PhpRectorInterface;
 use Rector\Core\Exception\ShouldNotHappenException;
-use Rector\Core\Exclusion\ExclusionManager;
 use Rector\Core\FileSystem\FilePathHelper;
 use Rector\Core\Logging\CurrentRectorProvider;
 use Rector\Core\NodeDecorator\CreatedByRuleDecorator;
@@ -93,8 +92,6 @@ abstract class AbstractRector extends NodeVisitorAbstract implements PhpRectorIn
 
     private SimpleCallableNodeTraverser $simpleCallableNodeTraverser;
 
-    private ExclusionManager $exclusionManager;
-
     private CurrentRectorProvider $currentRectorProvider;
 
     private CurrentNodeProvider $currentNodeProvider;
@@ -127,7 +124,6 @@ public function autowire(
         SimpleCallableNodeTraverser $simpleCallableNodeTraverser,
         NodeFactory $nodeFactory,
         PhpDocInfoFactory $phpDocInfoFactory,
-        ExclusionManager $exclusionManager,
         StaticTypeMapper $staticTypeMapper,
         CurrentRectorProvider $currentRectorProvider,
         CurrentNodeProvider $currentNodeProvider,
@@ -150,7 +146,6 @@ public function autowire(
         $this->simpleCallableNodeTraverser = $simpleCallableNodeTraverser;
         $this->nodeFactory = $nodeFactory;
         $this->phpDocInfoFactory = $phpDocInfoFactory;
-        $this->exclusionManager = $exclusionManager;
         $this->staticTypeMapper = $staticTypeMapper;
         $this->currentRectorProvider = $currentRectorProvider;
         $this->currentNodeProvider = $currentNodeProvider;
@@ -392,10 +387,6 @@ private function shouldSkipCurrentNode(Node $node): bool
             return true;
         }
 
-        if ($this->exclusionManager->isNodeSkippedByRector($node, static::class)) {
-            return true;
-        }
-
         $filePath = $this->file->getFilePath();
         if ($this->skipper->shouldSkipElementAndFilePath($this, $filePath)) {
             return true;