Skip to content

Fix ClassRenamePhpDocNodeVisitor with namespace check on auto import#3149

Merged
TomasVotruba merged 22 commits intomainfrom
fix-class-rename-auto-import
Dec 4, 2022
Merged

Fix ClassRenamePhpDocNodeVisitor with namespace check on auto import#3149
TomasVotruba merged 22 commits intomainfrom
fix-class-rename-auto-import

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Dec 4, 2022

The @noRector removal by PR:

cause error in tests :

There were 3 failures:

1) Rector\Tests\Renaming\Rector\Name\RenameClassRector\AutoImportNamesTest::test with data set #0 ('/home/runner/work/rector-src/...hp.inc')
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
     /**
      * @param DateTime $foo
      *
-     * @return Storage|\Illuminate\Support\Facades\Storage
+     * @return \Illuminate\Support\Facades\Storage|\Illuminate\Support\Facades\Storage
      */
     public function bar($foo){}

Ref https://github.com/rectorphp/rector-src/actions/runs/3608581525/jobs/6081273124#step:5:114

This PR try to fix it

@samsonasik samsonasik marked this pull request as draft December 4, 2022 04:18
@samsonasik samsonasik force-pushed the fix-class-rename-auto-import branch from 8b7f98d to 815b195 Compare December 4, 2022 04:54
@samsonasik samsonasik marked this pull request as ready for review December 4, 2022 05:19
@samsonasik
Copy link
Copy Markdown
Member Author

Finally 🎉 All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik samsonasik marked this pull request as draft December 4, 2022 06:37
@samsonasik samsonasik marked this pull request as ready for review December 4, 2022 06:49
@samsonasik
Copy link
Copy Markdown
Member Author

Finally 🎉 All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba TomasVotruba merged commit e14aac7 into main Dec 4, 2022
@TomasVotruba TomasVotruba deleted the fix-class-rename-auto-import branch December 4, 2022 11:47
@TomasVotruba
Copy link
Copy Markdown
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants