[PHP 8] Resources object upgrade - remove 2 rules as the upgrade require wholesome manual work

[TomasVotruba]

This upgrade depends on exact new feature of resources, see:

• https://www.php.net/manual/en/migration81.incompatible.php
• https://php.watch/articles/resource-object
• [PHP 8.1] Add upgrade from resource to objects rector#6749

They should be handled with resource or resource/object or object in mind. In latter use the object methods etc. This needs manual work with careful human touch :)

[kocsismate]

Hi @TomasVotruba,

I'm not really sure why this rule was removed, even by reading the description. Could you please tell me what kind of manual work is needed? As far as I remember, only the widely known is_resource($r) calls to $r !== false changes are needed to ensure BC apart from some edge-cases like this as well as the removal of some deprecated functions (e.g. shmop_close()).

[TomasVotruba]

Hi, it depends on the code base. The risky place here are strict type declarations. We applied this rule on one project, but it completely broke the rest of the code, as different types were not used there. Thus it's required to handle this manually and with caution.

Despite that, feel free to copy paste this rule in own custom set.