[e2e] $rectorConfig->skip() should not skip inside different path over config

[samsonasik]

@TomasVotruba @staabm this is e2e test for check the config:

    $rectorConfig->paths([
        __DIR__ . '/src',
    ]);

    $rectorConfig->skip([
        RemoveEmptyClassMethodRector::class => [
            __DIR__ . '/src/controllers',
        ],
    ]);

    $rectorConfig->rule(RemoveEmptyClassMethodRector::class);

which means, if the path is different, eg: src/models, it should still run, it currently show:

[WARNING] Register rules or sets in your "rector.php" config

which incorrect.

Directly use __DIR__ . '/src/controllers' in skip paths() seems completely skip all, not sure if there is different issue, that probably need separate PR.

[samsonasik]

@TomasVotruba $rectorConfig->skip() seems trying to read getcwd() which somehow can't goes to realpath(), and if we try on getrector demo site, it goes error: Unable to write file '/var/www/public/rector.php'. which strange

https://getrector.com/demo/5871515d-0885-4df1-bd65-ef36442d5703

[samsonasik]

@TomasVotruba it seems bug on ContainerMemento class, the service is unset() when using skip() even when define path over the skip class:

• rector-src/src/DependencyInjection/Laravel/ContainerMemento.php

  Line 28 in 8b07c8e

  unset($tags[$tagName][$key]);

[samsonasik]

@TomasVotruba @staabm fixed 🎉 , the forgetting service on skip() should only when path is not specified fec890d

[samsonasik]

All checks have passed 🎉 🎉 🎉 @TomasVotruba I think it is ready 🎉 🎉 🎉 🎉 🎉

[TomasVotruba]

Thank you 😊👍

[staabm]

is this flag still correct then?

[samsonasik]

That seems used on line 727 to run once on phpunit

[staabm]

could you give me an idea why we need to drop classes from the container when rules are skipped?

[samsonasik]

This @TomasVotruba blog post may be the reason https://tomasvotruba.com/blog/removing-service-from-laravel-container-is-not-that-easy

[staabm]

thanks for the fix!