[e2e] $rectorConfig->skip() should not skip inside different path over config

.github/workflows/e2e.yaml

@@ -33,6 +33,7 @@ jobs:
                     - 'e2e/parallel with space'
                     - 'e2e/wildcards-path-config'
                     - 'e2e/wildcards-path-import-config'
+                    - 'e2e/different-path-over-skip-config'
 
         name: End to end test - ${{ matrix.directory }}
 

e2e/different-path-over-skip-config/.gitignore

@@ -0,0 +1 @@
+/vendor

e2e/different-path-over-skip-config/composer.json

@@ -0,0 +1,7 @@
+{
+    "require": {
+        "php": "^8.1"
+    },
+    "minimum-stability": "dev",
+    "prefer-stable": true
+}

e2e/different-path-over-skip-config/expected-output.diff

@@ -0,0 +1,21 @@
+1 file with changes
+===================
+
+1) src/models/DeadConstructor.php:3
+
+    ---------- begin diff ----------
+@@ @@
+
+ final class DeadConstructor
+ {
+-    public function __construct()
+-    {
+-    }
+ }
+    ----------- end diff -----------
+
+Applied rules:
+ * RemoveEmptyClassMethodRector
+
+
+ [OK] 1 file would have changed (dry-run) by Rector

e2e/different-path-over-skip-config/rector.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->paths([
+        __DIR__ . '/src',
+    ]);
+
+    $rectorConfig->skip([
+        RemoveEmptyClassMethodRector::class => [
+            __DIR__ . '/src/controllers',
+        ],
+    ]);
+
+    $rectorConfig->rule(RemoveEmptyClassMethodRector::class);
+};

e2e/different-path-over-skip-config/src/controllers/DeadConstructor.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace controllers;
+
+final class DeadConstructor
+{
+    public function __construct()
+    {
+    }
+}

e2e/different-path-over-skip-config/src/models/DeadConstructor.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace model;
+
+final class DeadConstructor
+{
+    public function __construct()
+    {
+    }
+}

packages-tests/Skipper/Skipper/SkipperRectorRuleTest.php

@@ -31,14 +31,14 @@ public function testRemovingServiceFromContainer(): void
         // register 2 rules, but one is skipped
         $this->bootFromConfigFiles([__DIR__ . '/config/single_skipped_rule_config.php']);
 
-        $container = self::getContainer();
+        $rectorConfig = self::getContainer();
 
         // to invoke before resolving
-        $container->make(FileNodesFetcher::class);
+        $rectorConfig->make(FileNodesFetcher::class);
 
         // here 1 rule should be removed and 1 should remain
         /** @var RewindableGenerator<int, RectorInterface> $rectorsIterator */
-        $rectorsIterator = $container->tagged(RectorInterface::class);
+        $rectorsIterator = $rectorConfig->tagged(RectorInterface::class);
         $this->assertCount(1, $rectorsIterator);
 
         $rectors = iterator_to_array($rectorsIterator->getIterator());

src/DependencyInjection/LazyContainerFactory.php

@@ -729,9 +729,12 @@ static function (
             }
 
             $skippedClassResolver = new SkippedClassResolver();
-            $skippedClasses = array_keys($skippedClassResolver->resolve());
-            foreach ($skippedClasses as $skippedClass) {
-                ContainerMemento::forgetService($container, $skippedClass);
+            $skippedElements = $skippedClassResolver->resolve();
+            foreach ($skippedElements as $skippedClass => $path) {
+                // completely forget the Rector rule only when no path specified
+                if ($path === null) {
+                    ContainerMemento::forgetService($container, $skippedClass);
+                }
             }
 
             $hasForgotten = true;