[AutoImport][Php70] Keep FQCN on conflict last name on TernaryToNullCoalescingRector#5251
[AutoImport][Php70] Keep FQCN on conflict last name on TernaryToNullCoalescingRector#5251samsonasik merged 6 commits intomainfrom
Conversation
…llCoalescingRector
|
The issue seems only on no namespaced code, I added both namespaced and no namespaced fixture. |
|
@staabm the issue seems happen on static call: Hersteller::getListForProducts(new \ProductFilter());see https://getrector.com/demo/6129e6f8-3726-4d26-b961-306b42af6be6 when only use: new \ProductFilter();it seems working ok https://getrector.com/demo/813692b7-8f7a-49ea-9d55-fd1750e24573 so, the namespaced name somehow overlap under static call |
|
Finally fixed 🎉 /cc @staabm |
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
|
@staabm please try latest rector/rector:dev-main and verify if it working ok now :) |
|
@samsonasik verified locally. looks great - I cannot reproduce the issue in our project anymore. thank you |
|
may I ask for another bugfix release? :) |
|
@staabm sure 👍 , I just tagged 0.18.9 |
|
@staabm this will cause another bug on renaming FQN-ize name from no-namespace to namespace while auto import, see I will look into the fix :) |
Fixes rectorphp/rector#8309