Skip to content

[CodingStyle] Refactor UseImportsAdder to return [FileWithoutNamespace] code on no namespaced code#5254

Merged
samsonasik merged 2 commits intomainfrom
refactor-abstract-rector
Nov 16, 2023
Merged

[CodingStyle] Refactor UseImportsAdder to return [FileWithoutNamespace] code on no namespaced code#5254
samsonasik merged 2 commits intomainfrom
refactor-abstract-rector

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Nov 16, 2023

@TomasVotruba @staabm this is refactored version of patch on:

which ensure [FileWithoutNamespace] always set on UseImportsAdder

…e it returns [FileWithoutNamespace] code on no namespaced code
@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik samsonasik changed the title [Core] Refactor AbstractRector to add afterTraverse() method to ensure it returns [FileWithoutNamespace] code on no namespaced code [Core] Refactor AbstractRector to add afterTraverse() method to ensure it set [FileWithoutNamespace] code on no namespaced code Nov 16, 2023
@samsonasik samsonasik changed the title [Core] Refactor AbstractRector to add afterTraverse() method to ensure it set [FileWithoutNamespace] code on no namespaced code [Core] Refactor UseImportsAdder to return [FileWithoutNamespace] code on no namespaced code Nov 16, 2023
@samsonasik samsonasik changed the title [Core] Refactor UseImportsAdder to return [FileWithoutNamespace] code on no namespaced code [CodingStyle] Refactor UseImportsAdder to return [FileWithoutNamespace] code on no namespaced code Nov 16, 2023
@samsonasik
Copy link
Copy Markdown
Member Author

it works 🎉

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba @staabm I am merging it ;)

@samsonasik samsonasik merged commit 1595e34 into main Nov 16, 2023
@samsonasik samsonasik deleted the refactor-abstract-rector branch November 16, 2023 14:49
@samsonasik
Copy link
Copy Markdown
Member Author

I changed to UseImportsAdder instead to return [FileWithoutNamespace] on no namespaced code, and it seems working ok 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant