[CodeQuality] Skip inner function referenced as string callable in InnerFunctionToPrivateMethodRector#8154
Merged
Conversation
…nerFunctionToPrivateMethodRector
Member
Author
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9801
InnerFunctionToPrivateMethodRectoronly rewritesFuncCallreferences (inner()) when converting an inner function to a private method. If the inner function is referenced as a string callable (e.g.usort($items, 'sortByOrder')), that reference is aString_node and is left untouched — the function gets moved into a private method while the call site still points at a now non-existent global function. WithRemoveUnusedPrivateMethodRectoralso enabled, the "unused" method is then deleted entirely.This PR skips the transformation when the inner function name is referenced as a string within the method, keeping working code intact.
Before
was rewritten to broken code —
sortByOrder()moved to a private method, butusort($options, 'sortByOrder')still referencing the removed global function.After
No change — the inner function is left as-is, because it is referenced by string callable and cannot be safely rewritten.