[Php80] Skip promotion when property type is wider than constructor param on ClassPropertyAssignToConstructorPromotionRector

[ximki-vinki]

Fixes rectorphp/rector#9809

Summary

ClassPropertyAssignToConstructorPromotionRector no longer promotes when the property type is strictly wider than the constructor parameter type (e.g. ?object property vs object param). Promotion would copy the wider property type onto the constructor and loosen the constructor contract.

Narrowing cases (e.g. object property vs ?object param) still promote as before.

Repro from the issue: https://getrector.com/demo/980360e4-321c-4a02-ac29-7062848188cf

Changes

• Add shouldSkipWiderPropertyType() with shouldUsePropertyTypeForPromotedParam + isSubtype guard
• Add skip_wider_property_type.php.inc — no change expected (issue repro)
• Add narrower_property_type.php.inc — promotion with narrowing still works

Test plan

• vendor/bin/phpunit rules-tests/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector/ClassPropertyAssignToConstructorPromotionRectorTest.php
• composer complete-check

[TomasVotruba]

This is not the right solution, as default null doesn't change behavior at all. The problem is in the $this->value = null.
That's what rule should look for and if found, skip it.

[ximki-vinki]

This is not the right solution, as default null doesn't change behavior at all. The problem is in the $this->value = null. That's what rule should look for and if found, skip it.

Change solution

[TomasVotruba]

Suggested change

	public function __construct(private(set) ?object $entity)
	public function __construct(private(set) object $entity)

There is no null override and constructor always set an object, so ? should be removed.

[TomasVotruba]

👍